From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35788)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1R3SiW-00075Y-4g
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 09:08:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1R3SiS-0002V7-3k
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 09:08:00 -0400
Message-ID: <4E6F55D8.20802@suse.de>
Date: Tue, 13 Sep 2011 15:08:40 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1314865231-24433-1-git-send-email-chouteau@adacore.com>	<7F526FE3-48CD-45BE-8135-94901C26121D@suse.de>	<4E6782AC.9070603@adacore.com>	<765F067E-9AD5-4626-8740-1E6FC3A7571F@suse.de>	<4E69EC24.4030606@adacore.com>	<57B05115-B9BC-4E06-BA27-F415B27B0E86@suse.de>	<4E6A1440.9010201@adacore.com>	<67C14AF0-B34A-43C8-B9FB-43270D929F87@suse.de>	<4E6A212C.30709@adacore.com>	<1C102E0E-5ACA-4457-997D-DE4FCAC1F625@suse.de>
	<4E6E4018.3020106@freescale.com> <4E6F5560.4000506@adacore.com>
In-Reply-To: <4E6F5560.4000506@adacore.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc]  [RESEND][PATCH] booke timers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: Scott Wood <scottwood@freescale.com>, qemu-ppc@nongnu.org, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Fabien Chouteau wrote:
> On 12/09/2011 19:23, Scott Wood wrote:
>   
>> On 09/09/2011 09:58 AM, Alexander Graf wrote:
>>     
>>> On 09.09.2011, at 16:22, Fabien Chouteau wrote:
>>>       
>>>> if the interrupt is already set and you clear TCR.DIE, the interrupt has to
>>>> remain set. The only way to unset an interrupt is to clear the corresponding
>>>> bit in TSR (currently in store_booke_tsr).
>>>>         
>>> Are you sure? I see several things in the 2.06 spec:
>>>       
>> [snip]
>>     
>>> To me that sounds as if the decrementer interrupt gets injected only
>>> when TSR.DIS=1, TCR.DIE=1 and MSR.EE=1. Unsetting any of these bits
>>> stops the interrupt from being delivered.
>>>
>>> Scott, can you please check up with the hardware guys if this is correct?
>>>       
>> This is how I've always understood it to work (assuming the interrupt
>> hasn't already been delivered, of course).  Fabien, do you have real
>> hardware that you see behave the way you describe?
>>
>>     
>
> No I don't, it was just my understanding of Book-E documentation. I've tried
> your solution (below) with VxWorks, and it works like a charm.
>
> static void booke_update_irq(CPUState *env)
> {
>     ppc_set_irq(env, PPC_INTERRUPT_DECR,
>                 (env->spr[SPR_BOOKE_TSR] & TSR_DIS
>                  && env->spr[SPR_BOOKE_TCR] & TCR_DIE));
>
>     ppc_set_irq(env, PPC_INTERRUPT_WDT,
>                 (env->spr[SPR_BOOKE_TSR] & TSR_WIS
>                  && env->spr[SPR_BOOKE_TCR] & TCR_WIE));
>
>     ppc_set_irq(env, PPC_INTERRUPT_FIT,
>                 (env->spr[SPR_BOOKE_TSR] & TSR_FIS
>                  && env->spr[SPR_BOOKE_TCR] & TCR_FIE));
> }
>   

Awesome! Please also check on MSR.EE and send a new patch then :)


Alex