From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R3UjQ-0003zK-Bj
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:17:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R3UjK-0006ac-6B
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:17:04 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:64681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R3UjJ-0006aY-W3
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:16:58 -0400
Received: by qyc1 with SMTP id 1so527381qyc.4
	for <qemu-devel@nongnu.org>; Tue, 13 Sep 2011 08:16:57 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E6F73E5.3020303@redhat.com>
Date: Tue, 13 Sep 2011 17:16:53 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <871uvquxi0.wl%morita.kazutaka@lab.ntt.co.jp>
	<1315555898-16957-1-git-send-email-pbonzini@redhat.com>
	<4E6F652C.7080103@redhat.com>
In-Reply-To: <4E6F652C.7080103@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine
 send/recv function to generic code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

On 09/13/2011 04:14 PM, Kevin Wolf wrote:
>> >    block/sheepdog.c |  225 ++++++------------------------------------------------
>> >    cutils.c         |  103 +++++++++++++++++++++++++
>> >    qemu-common.h    |    3 +
>> >    qemu-coroutine.c |   70 +++++++++++++++++
>> >    qemu-coroutine.h |   26 ++++++
>
> Can we move the code somewhere else? This is not core coroutine
> infrastructure. I would suggest qemu_socket.h/qemu-sockets.c.

It's not really socket-specific either (it uses recv/send only because 
of Windows brokenness---it could use read/write if it wasn't for that). 
  I hoped sooner or later it could become a qemu_co_readv/writev, hence 
the choice of qemu-coroutine.c.

Paolo

ps: I also hope that the Earth will start spinning slower and will give 
me 32 hour days, so just tell me if you really want that outside 
qemu-coroutine.c.