qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Fabien Chouteau <chouteau@adacore.com>
Subject: Re: [Qemu-devel] [Qemu-ppc]  [RESEND][PATCH] booke timers
Date: Tue, 13 Sep 2011 11:44:16 -0500	[thread overview]
Message-ID: <4E6F8860.6030807@freescale.com> (raw)
In-Reply-To: <4E6F55D8.20802@suse.de>

On 09/13/2011 08:08 AM, Alexander Graf wrote:
> Fabien Chouteau wrote:
>> static void booke_update_irq(CPUState *env)
>> {
>>     ppc_set_irq(env, PPC_INTERRUPT_DECR,
>>                 (env->spr[SPR_BOOKE_TSR] & TSR_DIS
>>                  && env->spr[SPR_BOOKE_TCR] & TCR_DIE));
>>
>>     ppc_set_irq(env, PPC_INTERRUPT_WDT,
>>                 (env->spr[SPR_BOOKE_TSR] & TSR_WIS
>>                  && env->spr[SPR_BOOKE_TCR] & TCR_WIE));
>>
>>     ppc_set_irq(env, PPC_INTERRUPT_FIT,
>>                 (env->spr[SPR_BOOKE_TSR] & TSR_FIS
>>                  && env->spr[SPR_BOOKE_TCR] & TCR_FIE));
>> }
>>   
> 
> Awesome! Please also check on MSR.EE and send a new patch then :)

If you check on EE here, then you'll need to call booke_update_irq()
when EE changes (not sure whether that's the plan).  Another option
would be to unset the irq if the condition is not valid.  This would
also be better in that you could have all three set (DIS, DIE, EE) and
not deliver the interrupt because there's a higher priority exception.

-Scott

  parent reply	other threads:[~2011-09-13 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01  8:20 [Qemu-devel] [RESEND][PATCH] booke timers Fabien Chouteau
2011-09-06 19:33 ` Alexander Graf
2011-09-07 14:41   ` Fabien Chouteau
2011-09-07 19:59     ` Alexander Graf
2011-09-09 10:36       ` Fabien Chouteau
2011-09-09 10:55         ` Alexander Graf
2011-09-09 13:27           ` Fabien Chouteau
2011-09-09 13:46             ` Alexander Graf
2011-09-09 14:22               ` Fabien Chouteau
2011-09-09 14:58                 ` Alexander Graf
2011-09-12 17:23                   ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2011-09-13 13:06                     ` Fabien Chouteau
2011-09-13 13:08                       ` Alexander Graf
2011-09-13 13:13                         ` Alexander Graf
2011-09-13 13:28                           ` Fabien Chouteau
2011-09-13 16:44                         ` Scott Wood [this message]
2011-09-13 17:28                           ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6F8860.6030807@freescale.com \
    --to=scottwood@freescale.com \
    --cc=agraf@suse.de \
    --cc=chouteau@adacore.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).