From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R3m6E-00025r-Jy
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 05:49:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R3m6D-0000oi-OP
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 05:49:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24306)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R3m6D-0000oT-EH
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 05:49:45 -0400
Message-ID: <4E7078B4.6020203@redhat.com>
Date: Wed, 14 Sep 2011 12:49:40 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1315992222-24069-1-git-send-email-avi@redhat.com>
In-Reply-To: <1315992222-24069-1-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] Memory API mutators
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Peter Maydell <peter.maydell@linaro.org>, Jan Kiszka <jan.kiszka@siemens.com>

Jan, too, was interested in this.

On 09/14/2011 12:23 PM, Avi Kivity wrote:
> This patchset introduces memory_region_set_enabled() and
> memory_region_set_address() to avoid the requirement on memory
> routers to track the internal state of the memory API (so they know
> whether they need to add or remove a region).  Instead, they can
> simply copy the state of the region from the guest-exposed register
> to the memory core, via the new mutator functions.
>
> Please review.  Do we need a memory_region_set_size() as well?  Do we want
>
>    memory_region_set_attributes(mr,
>                                 MR_ATTR_ENABLED | MR_ATTR_SIZE,
>                                 (MemoryRegionAttributes) {
>                                     .enabled = s->enabled,
>                                     .address = s->addr,
>                                 });
>
> ?
>
> Avi Kivity (3):
>    memory: introduce memory_region_set_enabled()
>    memory: introduce memory_region_set_address()
>    memory: optimize empty transactions due to mutators
>
>   memory.c |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++---------
>   memory.h |   28 +++++++++++++++++++++++++++
>   2 files changed, 82 insertions(+), 10 deletions(-)
>


-- 
error compiling committee.c: too many arguments to function