From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3o90-00089u-5j for qemu-devel@nongnu.org; Wed, 14 Sep 2011 08:00:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3o8u-0001PL-V3 for qemu-devel@nongnu.org; Wed, 14 Sep 2011 08:00:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3o8u-0001Of-As for qemu-devel@nongnu.org; Wed, 14 Sep 2011 08:00:40 -0400 Message-ID: <4E709763.1080805@redhat.com> Date: Wed, 14 Sep 2011 15:00:35 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1315832873-18976-1-git-send-email-avi@redhat.com> In-Reply-To: <1315832873-18976-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel@nongnu.org On 09/12/2011 04:07 PM, Avi Kivity wrote: > i8259 is an ISA device (or at least, depends on the ISA infrastructure to > register its ioport); and the ISA bus is supplied by piix4. Later patches > make this dependency explicit. > > Move the i8259 initialization until after the ISA bus is created; and supply > a new qemu_irq to PCI initialization, since the i8259 isn't ready yet. Later > wire the new qemu_irq to the i8259. > Can this please be reviewed? It's in the front of the memory queue logjam. -- error compiling committee.c: too many arguments to function