* [Qemu-devel] [PULL] Memory core integer overflow fix
@ 2011-09-14 12:48 Avi Kivity
2011-09-15 19:10 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2011-09-14 12:48 UTC (permalink / raw)
To: Anthony Liguori, qemu-devel
Please pull from
git://github.com/avikivity/qemu.git memory/core
to receive a core fix for an integer overflow problem hitting ppc:
David Gibson (1):
Fix subtle integer overflow bug in memory API
memory.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/memory.c b/memory.c
index 57f0fa4..101b67c 100644
--- a/memory.c
+++ b/memory.c
@@ -55,8 +55,8 @@ static AddrRange addrrange_shift(AddrRange range,
int64_t delta)
static bool addrrange_intersects(AddrRange r1, AddrRange r2)
{
- return (r1.start >= r2.start && r1.start < r2.start + r2.size)
- || (r2.start >= r1.start && r2.start < r1.start + r1.size);
+ return (r1.start >= r2.start && (r1.start - r2.start) < r2.size)
+ || (r2.start >= r1.start && (r2.start - r1.start) < r1.size);
}
static AddrRange addrrange_intersection(AddrRange r1, AddrRange r2)
--
error compiling committee.c: too many arguments to function
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PULL] Memory core integer overflow fix
2011-09-14 12:48 [Qemu-devel] [PULL] Memory core integer overflow fix Avi Kivity
@ 2011-09-15 19:10 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-09-15 19:10 UTC (permalink / raw)
To: Avi Kivity; +Cc: qemu-devel
On 09/14/2011 07:48 AM, Avi Kivity wrote:
> Please pull from
>
> git://github.com/avikivity/qemu.git memory/core
>
> to receive a core fix for an integer overflow problem hitting ppc:
>
> David Gibson (1):
> Fix subtle integer overflow bug in memory API
Pulled. Thanks.
Regards,
Anthony Liguori
>
> memory.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index 57f0fa4..101b67c 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -55,8 +55,8 @@ static AddrRange addrrange_shift(AddrRange range, int64_t delta)
>
> static bool addrrange_intersects(AddrRange r1, AddrRange r2)
> {
> - return (r1.start >= r2.start && r1.start < r2.start + r2.size)
> - || (r2.start >= r1.start && r2.start < r1.start + r1.size);
> + return (r1.start >= r2.start && (r1.start - r2.start) < r2.size)
> + || (r2.start >= r1.start && (r2.start - r1.start) < r1.size);
> }
>
> static AddrRange addrrange_intersection(AddrRange r1, AddrRange r2)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-15 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-14 12:48 [Qemu-devel] [PULL] Memory core integer overflow fix Avi Kivity
2011-09-15 19:10 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).