From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3rJY-0005sr-LH for qemu-devel@nongnu.org; Wed, 14 Sep 2011 11:23:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3rJX-0004zA-RE for qemu-devel@nongnu.org; Wed, 14 Sep 2011 11:23:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3rJX-0004yw-K7 for qemu-devel@nongnu.org; Wed, 14 Sep 2011 11:23:51 -0400 Message-ID: <4E70C703.5000602@redhat.com> Date: Wed, 14 Sep 2011 18:23:47 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E6DAA09.1050701@twiddle.net> <4E6DCA61.4070009@siemens.com> <4E6DCCC4.1050201@redhat.com> <4E6DCE8D.9040602@siemens.com> <4E70C402.3090907@twiddle.net> In-Reply-To: <4E70C402.3090907@twiddle.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Blue Swirl , Jan Kiszka , qemu-devel On 09/14/2011 06:10 PM, Richard Henderson wrote: > > > > So the default address passed to the handler is now already relative? I > > think we should keep it like this for all converted devices, ie. take > > the chance, fix the remaining models, and drop the offset. > > It's non-zero for the isa portio conversion that I did, which > I thought was in Avi's tree. That's MemoryRegionPortio::offset, not MemoryRegion::offset. -- error compiling committee.c: too many arguments to function