From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45135)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3rNC-0008U2-CR
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 11:27:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3rNB-0005dH-19
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 11:27:38 -0400
Received: from mail-ew0-f53.google.com ([209.85.215.53]:57958)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3rNA-0005d4-S3
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 11:27:36 -0400
Received: by ewy8 with SMTP id 8so880202ewy.12
	for <qemu-devel@nongnu.org>; Wed, 14 Sep 2011 08:27:36 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E70C7E4.8070009@twiddle.net>
Date: Wed, 14 Sep 2011 08:27:32 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <CAAu8pHvpbYBuOKa6Krsd6R00qidBx+J6ObaqZT40zuYh+SZn9g@mail.gmail.com>
	<4E6DAA09.1050701@twiddle.net> <4E6DCA61.4070009@siemens.com>
	<4E6DCCC4.1050201@redhat.com> <4E6DCE8D.9040602@siemens.com>
	<4E70C402.3090907@twiddle.net> <4E70C703.5000602@redhat.com>
In-Reply-To: <4E70C703.5000602@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/14/2011 08:23 AM, Avi Kivity wrote:
> On 09/14/2011 06:10 PM, Richard Henderson wrote:
>> >
>> >  So the default address passed to the handler is now already relative? I
>> >  think we should keep it like this for all converted devices, ie. take
>> >  the chance, fix the remaining models, and drop the offset.
>>
>> It's non-zero for the isa portio conversion that I did, which
>> I thought was in Avi's tree.
> 
> That's MemoryRegionPortio::offset, not MemoryRegion::offset.

No, look in isa_register_portio_list:

        memory_region_init_io(region, ops, opaque, name, off_high - off_low);
        memory_region_set_offset(region, start + off_low);

That last line sets MemoryRegion::offset.


r~