From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3t8L-0004n2-Uk for qemu-devel@nongnu.org; Wed, 14 Sep 2011 13:20:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3t8K-0001Q2-HT for qemu-devel@nongnu.org; Wed, 14 Sep 2011 13:20:25 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:51243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3t8K-0001Pi-E0 for qemu-devel@nongnu.org; Wed, 14 Sep 2011 13:20:24 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p8EFxo1V001567 for ; Wed, 14 Sep 2011 11:59:50 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8EHKM9U209408 for ; Wed, 14 Sep 2011 13:20:22 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8EDK8It031704 for ; Wed, 14 Sep 2011 10:20:09 -0300 Message-ID: <4E70E253.2030800@us.ibm.com> Date: Wed, 14 Sep 2011 12:20:19 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314980106-3500-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Makefile: Remove 'tarbin' target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 09/14/2011 11:25 AM, Peter Maydell wrote: > Ping? Anthony? (I should probably have cc'd you in the first place, > sorry) Weird. I dropped this patch but I don't know why. Doesn't look like I sent out a mail about it. I'll requeue it. Regards, Anthony Liguori > > -- PMM > > On 2 September 2011 17:15, Peter Maydell wrote: >> Remove the 'tarbin' target -- it isn't used as part of the official >> QEMU release process, and it's out of date (various new bios files >> were never added to its list of files). It's better not to provide >> it at all than to have a broken makefile target we never use or test. >> >> (Creating a tarball by just pulling in binaries that have been installed >> directly to the system you're running the build on is a bad idea anyway: >> the better way to create a binary tarball would be just to install to >> a temporary DESTDIR and then tar up that.) >> >> Signed-off-by: Peter Maydell >> --- >> Who distributes binaries in tarballs these days anyway? :-) >> >> Makefile | 37 ------------------------------------- >> 1 files changed, 0 insertions(+), 37 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 8606849..4f2bda1 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -364,42 +364,5 @@ tar: >> cd /tmp&& tar zcvf ~/$(FILE).tar.gz $(FILE) --exclude CVS --exclude .git --exclude .svn >> rm -rf /tmp/$(FILE) >> >> -SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS)) >> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \ >> - $(patsubst %-softmmu,qemu-system-%, \ >> - $(SYSTEM_TARGETS))) >> - >> -USER_TARGETS=$(filter %-user,$(TARGET_DIRS)) >> -USER_PROGS=$(patsubst %-bsd-user,qemu-%, \ >> - $(patsubst %-darwin-user,qemu-%, \ >> - $(patsubst %-linux-user,qemu-%, \ >> - $(USER_TARGETS)))) >> - >> -# generate a binary distribution >> -tarbin: >> - cd /&& tar zcvf ~/qemu-$(VERSION)-$(ARCH).tar.gz \ >> - $(patsubst %,$(bindir)/%, $(SYSTEM_PROGS)) \ >> - $(patsubst %,$(bindir)/%, $(USER_PROGS)) \ >> - $(bindir)/qemu-img \ >> - $(bindir)/qemu-nbd \ >> - $(datadir)/bios.bin \ >> - $(datadir)/vgabios.bin \ >> - $(datadir)/vgabios-cirrus.bin \ >> - $(datadir)/ppc_rom.bin \ >> - $(datadir)/openbios-sparc32 \ >> - $(datadir)/openbios-sparc64 \ >> - $(datadir)/openbios-ppc \ >> - $(datadir)/pxe-e1000.rom \ >> - $(datadir)/pxe-eepro100.rom \ >> - $(datadir)/pxe-ne2k_pci.rom \ >> - $(datadir)/pxe-pcnet.rom \ >> - $(datadir)/pxe-rtl8139.rom \ >> - $(datadir)/pxe-virtio.rom \ >> - $(docdir)/qemu-doc.html \ >> - $(docdir)/qemu-tech.html \ >> - $(mandir)/man1/qemu.1 \ >> - $(mandir)/man1/qemu-img.1 \ >> - $(mandir)/man8/qemu-nbd.8 >> - >> # Include automatically generated dependency files >> -include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d qapi/*.d qga/*.d) >> -- >> 1.7.1