From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()
Date: Wed, 14 Sep 2011 12:34:36 -0700 [thread overview]
Message-ID: <4E7101CC.9060401@twiddle.net> (raw)
In-Reply-To: <1315821825-27492-1-git-send-email-peter.maydell@linaro.org>
On 09/12/2011 03:03 AM, Peter Maydell wrote:
> Remove the unused function tcg_out_addi() from the ARM TCG backend;
> this fixes a compilation failure on ARM hosts with newer gcc.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
> ---
> A previous patch from Richard Henderson for this compile failure:
> http://patchwork.ozlabs.org/patch/110400/
> was rejected, so here's another go. This simply removes the unused function,
> in line with the approach taken for ppc/ppc64 in commits 1a2eb162414 and
> c24a9c6ef94.
>
> If this is accepted I can do the equivalent patches for tcg/ia64 and tcg/s390
> (although those don't cause compile failures because the unused function
> happens to be marked 'inline'.)
If we ever need this function again, we can revive it from git.
I'm in favor of deleting all of these functions.
r~
next prev parent reply other threads:[~2011-09-14 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 10:03 [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi() Peter Maydell
2011-09-12 17:04 ` Stefan Weil
2011-09-12 17:30 ` Peter Maydell
2011-09-14 19:34 ` Richard Henderson [this message]
2011-09-23 10:07 ` Peter Maydell
2011-10-01 12:04 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7101CC.9060401@twiddle.net \
--to=rth@twiddle.net \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).