From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3vEI-0004zg-Lz
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 15:34:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3vEH-0003DM-9K
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 15:34:42 -0400
Received: from mail-gx0-f181.google.com ([209.85.161.181]:35756)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3vEH-0003D5-6r
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 15:34:41 -0400
Received: by gxk9 with SMTP id 9so2495758gxk.12
	for <qemu-devel@nongnu.org>; Wed, 14 Sep 2011 12:34:40 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E7101CC.9060401@twiddle.net>
Date: Wed, 14 Sep 2011 12:34:36 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1315821825-27492-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1315821825-27492-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On 09/12/2011 03:03 AM, Peter Maydell wrote:
> Remove the unused function tcg_out_addi() from the ARM TCG backend;
> this fixes a compilation failure on ARM hosts with newer gcc.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Richard Henderson <rth@twiddle.net>

> ---
> A previous patch from Richard Henderson for this compile failure:
>  http://patchwork.ozlabs.org/patch/110400/
> was rejected, so here's another go. This simply removes the unused function,
> in line with the approach taken for ppc/ppc64 in commits 1a2eb162414 and
> c24a9c6ef94.
> 
> If this is accepted I can do the equivalent patches for tcg/ia64 and tcg/s390
> (although those don't cause compile failures because the unused function
> happens to be marked 'inline'.)

If we ever need this function again, we can revive it from git.
I'm in favor of deleting all of these functions.


r~