From: Richard Henderson <rth@twiddle.net>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization
Date: Wed, 14 Sep 2011 13:32:49 -0700 [thread overview]
Message-ID: <4E710F71.5000506@twiddle.net> (raw)
In-Reply-To: <1315832873-18976-1-git-send-email-avi@redhat.com>
On 09/12/2011 06:07 AM, Avi Kivity wrote:
> +static void malta_isa_irq_handler(void *opaque, int n, int level)
> +{
> + MaltaISAState *s = opaque;
> +
> + if (s->i8259) {
> + qemu_set_irq(s->i8259[n], level);
> + }
> +}
Is there any point in the IF? I realize that there's an ordering
problem that requires the use of the memory indirection in order
to be able to provide *some* opaque value at the proper time, but
AFAICT the ->i8259 value will *always* be non-null at the point
this function is called. Am I wrong here?
Otherwise the approach looks correct.
r~
next prev parent reply other threads:[~2011-09-14 20:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 13:07 [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization Avi Kivity
2011-09-14 12:00 ` Avi Kivity
2011-09-14 16:19 ` Andreas Färber
2011-09-14 19:03 ` Stefan Weil
2011-09-14 20:17 ` Avi Kivity
2011-09-14 20:52 ` Edgar E. Iglesias
2011-09-15 5:23 ` Stefan Weil
2011-09-18 12:04 ` Avi Kivity
2011-09-15 5:56 ` Stefan Weil
2011-09-14 20:32 ` Richard Henderson [this message]
2011-09-14 20:37 ` Avi Kivity
2011-09-14 20:40 ` Richard Henderson
2011-09-16 13:19 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E710F71.5000506@twiddle.net \
--to=rth@twiddle.net \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).