From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3w8b-0000gi-Vv
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 16:32:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3w8Z-0007OO-Uq
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 16:32:53 -0400
Received: from mail-vw0-f51.google.com ([209.85.212.51]:42667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3w8Z-0007NV-SP
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 16:32:51 -0400
Received: by vws20 with SMTP id 20so3366517vws.10
	for <qemu-devel@nongnu.org>; Wed, 14 Sep 2011 13:32:51 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E710F71.5000506@twiddle.net>
Date: Wed, 14 Sep 2011 13:32:49 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1315832873-18976-1-git-send-email-avi@redhat.com>
In-Reply-To: <1315832873-18976-1-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization
 after piix4 initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/12/2011 06:07 AM, Avi Kivity wrote:
> +static void malta_isa_irq_handler(void *opaque, int n, int level)
> +{
> +    MaltaISAState *s = opaque;
> +
> +    if (s->i8259) {
> +        qemu_set_irq(s->i8259[n], level);
> +    }
> +}

Is there any point in the IF?  I realize that there's an ordering
problem that requires the use of the memory indirection in order
to be able to provide *some* opaque value at the proper time, but
AFAICT the ->i8259 value will *always* be non-null at the point
this function is called.  Am I wrong here?

Otherwise the approach looks correct.


r~