From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3wlO-0006rB-Sd for qemu-devel@nongnu.org; Wed, 14 Sep 2011 17:12:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3wlN-00055v-Ob for qemu-devel@nongnu.org; Wed, 14 Sep 2011 17:12:58 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:54386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3wlN-00054u-Kf for qemu-devel@nongnu.org; Wed, 14 Sep 2011 17:12:57 -0400 Received: from /spool/local by us.ibm.com with XMail ESMTP for from ; Wed, 14 Sep 2011 17:12:55 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8ELCq5R3145738 for ; Wed, 14 Sep 2011 17:12:52 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8ELCq7a028782 for ; Wed, 14 Sep 2011 17:12:52 -0400 Message-ID: <4E7118D0.3000001@linux.vnet.ibm.com> Date: Wed, 14 Sep 2011 17:12:48 -0400 From: Stefan Berger MIME-Version: 1.0 References: <4E70DEE8.8090908@linux.vnet.ibm.com> <20110914174020.GB21891@redhat.com> <4E70E93E.9000509@linux.vnet.ibm.com> <20110914175621.GD21891@redhat.com> In-Reply-To: <20110914175621.GD21891@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Design of the blobstore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , QEMU Developers , Markus Armbruster On 09/14/2011 01:56 PM, Michael S. Tsirkin wrote: > On Wed, Sep 14, 2011 at 01:49:50PM -0400, Stefan Berger wrote: >> On 09/14/2011 01:40 PM, Michael S. Tsirkin wrote: >>> On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: >>>> qemu ... \ >>>> -blobstore name=my-blobstore,drive=tpm-bs,showsize \ >>>> -drive if=none,id=tpm-bs \ >>>> -tpmdev libtpms,blobstore=my-blobstore,id=tpm0 \ >>>> -device tpm-tis,tpmdev=tpm0 >>>> >>>> which would result in QEMU printing to stdout: >>>> >>>> Blobstore tpm-store on drive with ID tpm-bs requires 83kb. >>> So you envision tools parsing this freetext then? >>> Seems like a step back, we are trying to move to QMP ... >> I extended it first for the way I typically interact with QEMU. I do >> not use the monitor much. > It will work even better if there's a tool to do the job instead of cut > and pasting stuff, won't it? And for that, we need monitor commands. > I am not so sure about the design of the QMP commands and how to break things up into individual calls. So does this sequence here and the 'query-blobstore' output look ok? { "execute": "qmp_capabilities" } {"return": {}} { "execute": "query-blobstore" } {"return": [{"size": 84480, "id": "tpm-bs"}]} Corresponding command line parameters are: -tpmdev libtpms,blobstore=tpm-bs,id=tpm0 \ -drive if=none,id=tpm-bs,file=$TPMSTATE \ Regards, Stefan >>> So with above, the raw case which we don't expect to be used often >>> is easy to use, but qcow which we expect to be the main case >>> is close to imposible, involving manual cut and paste >>> of image size. >>> >>> Formatting images seems a rare enough occasion, >>> that I think only using monitor command for that >>> would be a better idea than a ton of new command >>> line options. On top of that, let's write a >>> script that run qemu, queries image size, >>> creates a qcow2 file, run qemu again to format, >>> all this using QMP. >> Creates the qcow2 using 'qemu-img' I suppose. >> >> Stefan > Sure. > >>> WRT 'format and run in one go' I strongly disagree with it. >>> It's just too easy to shoot oneself in the foot.