From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R44wO-0004Jy-2z for qemu-devel@nongnu.org; Thu, 15 Sep 2011 01:56:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R44wM-0001rs-Ou for qemu-devel@nongnu.org; Thu, 15 Sep 2011 01:56:52 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:52999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R44wM-0001rk-J4 for qemu-devel@nongnu.org; Thu, 15 Sep 2011 01:56:50 -0400 Message-ID: <4E71939F.8050400@mail.berlios.de> Date: Thu, 15 Sep 2011 07:56:47 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1315832873-18976-1-git-send-email-avi@redhat.com> <4E709763.1080805@redhat.com> In-Reply-To: <4E709763.1080805@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Am 14.09.2011 14:00, schrieb Avi Kivity: > On 09/12/2011 04:07 PM, Avi Kivity wrote: >> i8259 is an ISA device (or at least, depends on the ISA >> infrastructure to >> register its ioport); and the ISA bus is supplied by piix4. Later >> patches >> make this dependency explicit. >> >> Move the i8259 initialization until after the ISA bus is created; and >> supply >> a new qemu_irq to PCI initialization, since the i8259 isn't ready >> yet. Later >> wire the new qemu_irq to the i8259. >> > > Can this please be reviewed? It's in the front of the memory queue > logjam. > Tested-by: Stefan Weil Test configurations: 1. Debian lenny, qemu-system-mipsel (32 bit little endian), MIPS Malta 2. Debian lenny, qemu-system-mips64 (64 bit big endian), MIPS Malta Both work on a i386 linux host with the patch applied.