From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R453z-0005HV-Ak for qemu-devel@nongnu.org; Thu, 15 Sep 2011 02:04:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R453y-00048p-GG for qemu-devel@nongnu.org; Thu, 15 Sep 2011 02:04:43 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:63550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R453y-00047z-Bg for qemu-devel@nongnu.org; Thu, 15 Sep 2011 02:04:42 -0400 Received: by fxh13 with SMTP id 13so346916fxh.4 for ; Wed, 14 Sep 2011 23:04:41 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E71956B.6030902@redhat.com> Date: Thu, 15 Sep 2011 08:04:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1315628610-28222-1-git-send-email-ronniesahlberg@gmail.com> <1315628610-28222-2-git-send-email-ronniesahlberg@gmail.com> <20110912091408.GA3465@stefanha-thinkpad.localdomain> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ronnie sahlberg Cc: kwolf@redhat.com, fujita.tomonori@lab.ntt.co.jp, hch@lst.de, Stefan Hajnoczi , qemu-devel@nongnu.org On 09/15/2011 01:08 AM, ronnie sahlberg wrote: > I think it is reasonable to just not support iscsi at all for > blocksize that is not multiple of 512 bytes > since a read-modify-write cycle across a network would probably be > prohibitively expensive. Agreed. > .bdrv_flush() I can easily add a synchronous implementation of this > unless your patch is expected to be merged > in the near future. We need the same patch for NBD, so I wouldn't bother with the synchronous flush. Paolo