From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R45nd-0004KV-W0 for qemu-devel@nongnu.org; Thu, 15 Sep 2011 02:51:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R45nd-00068k-0h for qemu-devel@nongnu.org; Thu, 15 Sep 2011 02:51:53 -0400 Sender: Paolo Bonzini Message-ID: <4E71A084.9080600@redhat.com> Date: Thu, 15 Sep 2011 08:51:48 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1315989802-18753-1-git-send-email-agraf@suse.de> <1315989802-18753-4-git-send-email-agraf@suse.de> <20110915031529.GS9025@yookeroo.fritz.box> In-Reply-To: <20110915031529.GS9025@yookeroo.fritz.box> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/58] spapr: make irq customizable via qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel Developers , qemu-ppc@nongnu.org, Blue Swirl , Aurelien Jarno On 09/15/2011 05:15 AM, David Gibson wrote: >> > >> > This also lets the user see the irq in "info qtree". > Um.. I'm a bit confused by this one. The previous patch comment > implies it's a preparation for this, but then you add the new irq > property to the BusInfo, rather than to the macro that goes into the > DeviceInfos. Why does this one go in the bus, rather than the device? Yes, I suppose that the commit message for patch 2 is a bit stale. I put this one in the bus, rather than the device, because the default is common to all devices. Instead, each device type has its own default reg and default dma-window. Paolo