From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size
Date: Thu, 15 Sep 2011 09:33:49 +0200 [thread overview]
Message-ID: <4E71AA5D.2070400@redhat.com> (raw)
In-Reply-To: <1316022540-31355-2-git-send-email-peter.maydell@linaro.org>
On 09/14/11 19:48, Peter Maydell wrote:
> Honour the maximum packet size for endpoints; this applies when
> sending non-isochronous data and means we transfer only as
> much as the endpoint allows, leaving the transfer descriptor
> on the list for another go next time around. This allows
> usb-net to work when connected to an OHCI controller model.
Hmm, I'd tend to fix it the other way around: Fix usb-net to deal with
transfers larger than the endpoint packet size. What do you think?
cheers,
Gerd
next prev parent reply other threads:[~2011-09-15 7:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 17:48 [Qemu-devel] [PATCH 0/2] usb-ohci: fixes to allow usb-net to work Peter Maydell
2011-09-14 17:48 ` [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size Peter Maydell
2011-09-15 7:33 ` Gerd Hoffmann [this message]
2011-09-15 8:36 ` Peter Maydell
2011-09-15 9:13 ` Gerd Hoffmann
2011-09-15 10:08 ` Peter Maydell
2011-09-15 10:49 ` Gerd Hoffmann
2011-09-15 11:24 ` Peter Maydell
2011-09-15 11:45 ` Gerd Hoffmann
2011-09-14 17:49 ` [Qemu-devel] [PATCH 2/2] hw/usb-ohci: Fix OHCI_TD_T1 bit position definition Peter Maydell
2011-09-15 7:34 ` Gerd Hoffmann
2011-10-10 16:44 ` [Qemu-devel] [PATCH 0/2] usb-ohci: fixes to allow usb-net to work Peter Maydell
2011-10-11 7:10 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E71AA5D.2070400@redhat.com \
--to=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).