From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R46SP-0004VR-Qs for qemu-devel@nongnu.org; Thu, 15 Sep 2011 03:34:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R46SK-0006Gu-2l for qemu-devel@nongnu.org; Thu, 15 Sep 2011 03:34:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R46SJ-0006Gh-Rp for qemu-devel@nongnu.org; Thu, 15 Sep 2011 03:33:56 -0400 Message-ID: <4E71AA5D.2070400@redhat.com> Date: Thu, 15 Sep 2011 09:33:49 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1316022540-31355-1-git-send-email-peter.maydell@linaro.org> <1316022540-31355-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1316022540-31355-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 09/14/11 19:48, Peter Maydell wrote: > Honour the maximum packet size for endpoints; this applies when > sending non-isochronous data and means we transfer only as > much as the endpoint allows, leaving the transfer descriptor > on the list for another go next time around. This allows > usb-net to work when connected to an OHCI controller model. Hmm, I'd tend to fix it the other way around: Fix usb-net to deal with transfers larger than the endpoint packet size. What do you think? cheers, Gerd