From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R47uy-0001a0-CE
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 05:07:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R47ux-0000Fj-4w
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 05:07:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63669)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R47uw-0000F7-Sj
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 05:07:35 -0400
Message-ID: <4E71C102.103@redhat.com>
Date: Thu, 15 Sep 2011 11:10:26 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1315628610-28222-1-git-send-email-ronniesahlberg@gmail.com>
	<1315628610-28222-2-git-send-email-ronniesahlberg@gmail.com>
	<20110912091408.GA3465@stefanha-thinkpad.localdomain>
	<CAN05THSb51aX58AXjH_-Vdv=NFjHpw9T0at9b1jbwierhcij=w@mail.gmail.com>
	<4E71956B.6030902@redhat.com>
In-Reply-To: <4E71956B.6030902@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: fujita.tomonori@lab.ntt.co.jp, Christoph Hellwig <hch@lst.de>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, ronnie sahlberg <ronniesahlberg@gmail.com>, qemu-devel@nongnu.org

Am 15.09.2011 08:04, schrieb Paolo Bonzini:
> On 09/15/2011 01:08 AM, ronnie sahlberg wrote:
>> I think it is reasonable to just not support iscsi at all for
>> blocksize that is not multiple of 512 bytes
>> since a read-modify-write cycle across a network would probably be
>> prohibitively expensive.
> 
> Agreed.
> 
>> .bdrv_flush() I can easily add a synchronous implementation of this
>> unless your patch is expected to be merged
>> in the near future.
> 
> We need the same patch for NBD, so I wouldn't bother with the 
> synchronous flush.

Doesn't Stefan's patch conflict with your bdrv_co_flush patch?

Long term I think we should get rid of bdrv_flush and bdrv_aio_flush and
make all drivers use bdrv_co_flush. Having three different interfaces
for flush and emulation functions that do mappings for all missing
implementations is just insane.

Kevin