From: Alexander Graf <agraf@suse.de>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: scottwood@freescale.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V4] booke timers
Date: Thu, 15 Sep 2011 13:37:28 +0200 [thread overview]
Message-ID: <4E71E378.3000000@suse.de> (raw)
In-Reply-To: <1315922432-19607-1-git-send-email-chouteau@adacore.com>
On 09/13/2011 04:00 PM, Fabien Chouteau wrote:
> While working on the emulation of the freescale p2010 (e500v2) I realized that
> there's no implementation of booke's timers features. Currently mpc8544 uses
> ppc_emb (ppc_emb_timers_init) which is close but not exactly like booke (for
> example booke uses different SPR).
>
> Signed-off-by: Fabien Chouteau<chouteau@adacore.com>
> ---
>
> V2:
> - Fix fixed timer, now trigger each time the selected
> bit switch from 0 to 1.
> - Fix e500 criterion.
> - Trigger an interrupt when user set DIE/FIE/WIE while
> DIS/FIS/WIS is already set.
> - Minor fixes (mask definition, variable name...).
> - Rename ppc_emb to ppc_40x
>
> V3:
>
> - Fix bit selection for e500 fixed timers (fp == 000000 selects msb)
> - Improved formula to compute the next event of a fixed timer
>
> v4:
>
> - Centralized interrupt handling
> - Timer flags (BOOKE, E500, DECR_UNDERFLOW_TRIGGERED, DECR_ZERO_TRIGGERED)
Very nice, thank you so much!
Applied to ppc-next.
Alex
prev parent reply other threads:[~2011-09-15 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 14:00 [Qemu-devel] [PATCH V4] booke timers Fabien Chouteau
2011-09-15 11:37 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E71E378.3000000@suse.de \
--to=agraf@suse.de \
--cc=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).