From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4AFO-0001z7-HX for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:36:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4AFN-0003JW-EV for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:36:50 -0400 Message-ID: <4E71E378.3000000@suse.de> Date: Thu, 15 Sep 2011 13:37:28 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1315922432-19607-1-git-send-email-chouteau@adacore.com> In-Reply-To: <1315922432-19607-1-git-send-email-chouteau@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4] booke timers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: scottwood@freescale.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 09/13/2011 04:00 PM, Fabien Chouteau wrote: > While working on the emulation of the freescale p2010 (e500v2) I realized that > there's no implementation of booke's timers features. Currently mpc8544 uses > ppc_emb (ppc_emb_timers_init) which is close but not exactly like booke (for > example booke uses different SPR). > > Signed-off-by: Fabien Chouteau > --- > > V2: > - Fix fixed timer, now trigger each time the selected > bit switch from 0 to 1. > - Fix e500 criterion. > - Trigger an interrupt when user set DIE/FIE/WIE while > DIS/FIS/WIS is already set. > - Minor fixes (mask definition, variable name...). > - Rename ppc_emb to ppc_40x > > V3: > > - Fix bit selection for e500 fixed timers (fp == 000000 selects msb) > - Improved formula to compute the next event of a fixed timer > > v4: > > - Centralized interrupt handling > - Timer flags (BOOKE, E500, DECR_UNDERFLOW_TRIGGERED, DECR_ZERO_TRIGGERED) Very nice, thank you so much! Applied to ppc-next. Alex