From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size
Date: Thu, 15 Sep 2011 13:45:03 +0200 [thread overview]
Message-ID: <4E71E53F.4090101@redhat.com> (raw)
In-Reply-To: <CAFEAcA8skRftg8g2wK53zr6hGQ=E=gWdUSsefvFwAS5PvmwwJw@mail.gmail.com>
On 09/15/11 13:24, Peter Maydell wrote:
> On 15 September 2011 11:49, Gerd Hoffmann<kraxel@redhat.com> wrote:
>> Peter Maydell wrote:
>>> It seems to me that at least some of that is likely to be
>>> guest-visible, especially in the case where an endpoint returns an
>>> error partway through. So it's not clear to me that you could
>>> validly batch up everything in the TD and do it all at once.
>>
>> I think the only guest-visible effect is that the guest will never ever see
>> an partially filled transfer block, it is either empty or completely filled
>> (except on short transfers).
>
> Hmm, maybe. Anyway, can we have this committed as a bug fix
> for the current design pending you redoing this with your
> new approach, please?
Fair enouth. Added to the patch queue.
cheers,
Gerd
next prev parent reply other threads:[~2011-09-15 11:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 17:48 [Qemu-devel] [PATCH 0/2] usb-ohci: fixes to allow usb-net to work Peter Maydell
2011-09-14 17:48 ` [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size Peter Maydell
2011-09-15 7:33 ` Gerd Hoffmann
2011-09-15 8:36 ` Peter Maydell
2011-09-15 9:13 ` Gerd Hoffmann
2011-09-15 10:08 ` Peter Maydell
2011-09-15 10:49 ` Gerd Hoffmann
2011-09-15 11:24 ` Peter Maydell
2011-09-15 11:45 ` Gerd Hoffmann [this message]
2011-09-14 17:49 ` [Qemu-devel] [PATCH 2/2] hw/usb-ohci: Fix OHCI_TD_T1 bit position definition Peter Maydell
2011-09-15 7:34 ` Gerd Hoffmann
2011-10-10 16:44 ` [Qemu-devel] [PATCH 0/2] usb-ohci: fixes to allow usb-net to work Peter Maydell
2011-10-11 7:10 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E71E53F.4090101@redhat.com \
--to=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).