From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4ANT-0006xw-4E for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:45:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4ANS-0004zC-3k for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:45:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4ANR-0004z2-Nx for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:45:10 -0400 Message-ID: <4E71E53F.4090101@redhat.com> Date: Thu, 15 Sep 2011 13:45:03 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1316022540-31355-1-git-send-email-peter.maydell@linaro.org> <1316022540-31355-2-git-send-email-peter.maydell@linaro.org> <4E71AA5D.2070400@redhat.com> <4E71C1B0.5070607@redhat.com> <4E71D851.80501@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 09/15/11 13:24, Peter Maydell wrote: > On 15 September 2011 11:49, Gerd Hoffmann wrote: >> Peter Maydell wrote: >>> It seems to me that at least some of that is likely to be >>> guest-visible, especially in the case where an endpoint returns an >>> error partway through. So it's not clear to me that you could >>> validly batch up everything in the TD and do it all at once. >> >> I think the only guest-visible effect is that the guest will never ever see >> an partially filled transfer block, it is either empty or completely filled >> (except on short transfers). > > Hmm, maybe. Anyway, can we have this committed as a bug fix > for the current design pending you redoing this with your > new approach, please? Fair enouth. Added to the patch queue. cheers, Gerd