From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37271)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R4ESI-0003zz-BZ
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 12:06:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R4ESG-0003GF-VB
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 12:06:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11772)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R4ESG-0003G9-Ms
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 12:06:24 -0400
Message-ID: <4E722279.2030007@redhat.com>
Date: Thu, 15 Sep 2011 18:06:17 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <CAA=zYJauYBODqRDwZ4nXoopmcOUqRNUr-b9MZeEtV-UxvLT_6A@mail.gmail.com>
In-Reply-To: <CAA=zYJauYBODqRDwZ4nXoopmcOUqRNUr-b9MZeEtV-UxvLT_6A@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] usb: change VID/PID for usb-hub and
 usb-msd to	prevent conflict
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roy Tam <roytam@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 09/15/11 05:25, Roy Tam wrote:
> Some USB drivers, for example USBASPI.SYS, will skip different type of
> device which has same VID/PID. The following patch helps preventing
> usb-msd being skipped by the driver.

How and why did you pick those IDs?

>   static const USBDesc desc_hub = {
>       .id = {
> -        .idVendor          = 0,
> -        .idProduct         = 0,
> +        .idVendor          = 0x0409,
> +        .idProduct         = 0x55aa,

lsusb says: Bus 004 Device 002: ID 0409:55aa NEC Corp. Hub

Looks sensible.  Is that actually a USB 1.1 Hub?

>   static const USBDesc desc = {
>       .id = {
> -        .idVendor          = 0,
> -        .idProduct         = 0,
> +        .idVendor          = 0x46f4,
> +        .idProduct         = 0x0001,

lsusb doesn't find those IDs in the database.

cheers,
   Gerd