From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse
Date: Fri, 16 Sep 2011 08:12:46 -0500 [thread overview]
Message-ID: <4E734B4E.1070702@codemonkey.ws> (raw)
In-Reply-To: <cover.1315918309.git.quintela@redhat.com>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
malc, please Ack.
Regards,
Anthony Liguori
On 09/13/2011 07:52 AM, Juan Quintela wrote:
> Hi
>
> QEMUFile is intended to be used only for migration. Change the other
> three users to use FILE * operations directly. gcc on Fedora 15
> complains about fread/write not checking its return value, so I added
> checks. But in several places only print an error message (there is
> no error handly that I can hook into). Notice that this is not worse
> than it is today.
>
> Later, Juan.
>
> Juan Quintela (3):
> vawaudio: port to FILE*
> wavcapture: port to FILE*
> ds1225y: port to FILE*
>
> audio/wavaudio.c | 28 +++++++++++++++++++---------
> audio/wavcapture.c | 38 +++++++++++++++++++++++++-------------
> hw/ds1225y.c | 28 ++++++++++++++++------------
> 3 files changed, 60 insertions(+), 34 deletions(-)
>
next prev parent reply other threads:[~2011-09-16 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 12:52 [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse Juan Quintela
2011-09-13 12:52 ` [Qemu-devel] [PATCH 1/3] vawaudio: port to FILE* Juan Quintela
2011-09-13 12:52 ` [Qemu-devel] [PATCH 2/3] wavcapture: " Juan Quintela
2011-09-13 12:52 ` [Qemu-devel] [PATCH 3/3] ds1225y: " Juan Quintela
2011-09-16 13:12 ` Anthony Liguori [this message]
2011-09-16 22:51 ` [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse malc
2011-09-18 20:07 ` Juan Quintela
2011-09-18 20:30 ` malc
2011-09-19 21:03 ` Juan Quintela
2011-09-20 5:53 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E734B4E.1070702@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).