From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4YDr-0001Qk-9u for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:12:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4YDq-0001yh-4W for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:12:51 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:64498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4YDq-0001yZ-24 for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:12:50 -0400 Received: by yib2 with SMTP id 2so3519021yib.4 for ; Fri, 16 Sep 2011 06:12:49 -0700 (PDT) Message-ID: <4E734B4E.1070702@codemonkey.ws> Date: Fri, 16 Sep 2011 08:12:46 -0500 From: Anthony Liguori MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org Reviewed-by: Anthony Liguori malc, please Ack. Regards, Anthony Liguori On 09/13/2011 07:52 AM, Juan Quintela wrote: > Hi > > QEMUFile is intended to be used only for migration. Change the other > three users to use FILE * operations directly. gcc on Fedora 15 > complains about fread/write not checking its return value, so I added > checks. But in several places only print an error message (there is > no error handly that I can hook into). Notice that this is not worse > than it is today. > > Later, Juan. > > Juan Quintela (3): > vawaudio: port to FILE* > wavcapture: port to FILE* > ds1225y: port to FILE* > > audio/wavaudio.c | 28 +++++++++++++++++++--------- > audio/wavcapture.c | 38 +++++++++++++++++++++++++------------- > hw/ds1225y.c | 28 ++++++++++++++++------------ > 3 files changed, 60 insertions(+), 34 deletions(-) >