* [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support
@ 2011-09-14 14:16 Boris Dolgov
2011-09-16 13:13 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Boris Dolgov @ 2011-09-14 14:16 UTC (permalink / raw)
To: qemu-devel
Hello!
Qemu 0.15.0 doesn't build with vnc support disabled. The following
patch fixes the problem.
Signed-off-by: Boris Dolgov <boris@dolgov.name>
--
--- monitor.c.orig 2011-09-14 18:11:12.235199764 +0400
+++ monitor.c 2011-09-14 18:12:19.187709823 +0400
@@ -1200,10 +1200,12 @@ static int add_graphics_client(Monitor *
}
qerror_report(QERR_ADD_CLIENT_FAILED);
return -1;
+#ifdef CONFIG_VNC
} else if (strcmp(protocol, "vnc") == 0) {
int fd = monitor_get_fd(mon, fdname);
vnc_display_add_client(NULL, fd, skipauth);
return 0;
+#endif
} else if ((s = qemu_chr_find(protocol)) != NULL) {
int fd = monitor_get_fd(mon, fdname);
if (qemu_chr_add_client(s, fd) < 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support
2011-09-14 14:16 [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support Boris Dolgov
@ 2011-09-16 13:13 ` Anthony Liguori
2011-09-16 13:23 ` Luiz Capitulino
0 siblings, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2011-09-16 13:13 UTC (permalink / raw)
To: Boris Dolgov; +Cc: qemu-devel
On 09/14/2011 09:16 AM, Boris Dolgov wrote:
> Hello!
>
> Qemu 0.15.0 doesn't build with vnc support disabled. The following
> patch fixes the problem.
>
> Signed-off-by: Boris Dolgov<boris@dolgov.name>
Please submit patches against the latest git tree (and use git diff to generate
the diff).
Regards,
Anthony Liguori
>
> --
>
> --- monitor.c.orig 2011-09-14 18:11:12.235199764 +0400
> +++ monitor.c 2011-09-14 18:12:19.187709823 +0400
> @@ -1200,10 +1200,12 @@ static int add_graphics_client(Monitor *
> }
> qerror_report(QERR_ADD_CLIENT_FAILED);
> return -1;
> +#ifdef CONFIG_VNC
> } else if (strcmp(protocol, "vnc") == 0) {
> int fd = monitor_get_fd(mon, fdname);
> vnc_display_add_client(NULL, fd, skipauth);
> return 0;
> +#endif
> } else if ((s = qemu_chr_find(protocol)) != NULL) {
> int fd = monitor_get_fd(mon, fdname);
> if (qemu_chr_add_client(s, fd)< 0) {
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support
2011-09-16 13:13 ` Anthony Liguori
@ 2011-09-16 13:23 ` Luiz Capitulino
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Capitulino @ 2011-09-16 13:23 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Boris Dolgov, qemu-devel
On Fri, 16 Sep 2011 08:13:29 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 09/14/2011 09:16 AM, Boris Dolgov wrote:
> > Hello!
> >
> > Qemu 0.15.0 doesn't build with vnc support disabled. The following
> > patch fixes the problem.
> >
> > Signed-off-by: Boris Dolgov<boris@dolgov.name>
>
> Please submit patches against the latest git tree (and use git diff to generate
> the diff).
It's for stable. I'll submit it there myself.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support
@ 2011-09-21 7:21 wenyi
0 siblings, 0 replies; 4+ messages in thread
From: wenyi @ 2011-09-21 7:21 UTC (permalink / raw)
To: qemu-devel
Hello!
Qemu 0.15.0 doesn't build with vnc support disabled. The
following
patch fixes the problem.
Signed-off-by: Boris Dolgov <address@hidden>
--
--- monitor.c.orig 2011-09-14 18:11:12.235199764 +0400
+++ monitor.c 2011-09-14 18:12:19.187709823 +0400
@@ -1200,10 +1200,12 @@ static int add_graphics_client(Monitor *
}
qerror_report(QERR_ADD_CLIENT_FAILED);
return -1;
+#ifdef CONFIG_VNC
} else if (strcmp(protocol, "vnc") == 0) {
int fd = monitor_get_fd(mon, fdname);
vnc_display_add_client(NULL, fd, skipauth);
return 0;
+#endif
} else if ((s = qemu_chr_find(protocol)) != NULL) {
int fd = monitor_get_fd(mon, fdname);
if (qemu_chr_add_client(s, fd) < 0) {
Yes, the patch works fine.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-21 7:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-14 14:16 [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support Boris Dolgov
2011-09-16 13:13 ` Anthony Liguori
2011-09-16 13:23 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2011-09-21 7:21 wenyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).