From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:32830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4YTF-00079R-MJ for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4YTB-0008Db-C3 for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:28:45 -0400 Received: from mail-gw0-f53.google.com ([74.125.83.53]:46370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4YTB-0008DW-8J for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:28:41 -0400 Received: by gwj20 with SMTP id 20so3759465gwj.12 for ; Fri, 16 Sep 2011 06:28:40 -0700 (PDT) Message-ID: <4E734F05.3010002@codemonkey.ws> Date: Fri, 16 Sep 2011 08:28:37 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314980106-3500-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1314980106-3500-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Makefile: Remove 'tarbin' target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 09/02/2011 11:15 AM, Peter Maydell wrote: > Remove the 'tarbin' target -- it isn't used as part of the official > QEMU release process, and it's out of date (various new bios files > were never added to its list of files). It's better not to provide > it at all than to have a broken makefile target we never use or test. > > (Creating a tarball by just pulling in binaries that have been installed > directly to the system you're running the build on is a bad idea anyway: > the better way to create a binary tarball would be just to install to > a temporary DESTDIR and then tar up that.) > > Signed-off-by: Peter Maydell Can you rebase this patch? git-am things this patch was already applied which is why I dropped it in the first place. It's because the SYSTEM_PROGS variable has changed a little bit from when you first submitted. Regards, Anthony Liguori > --- > Who distributes binaries in tarballs these days anyway? :-) > > Makefile | 37 ------------------------------------- > 1 files changed, 0 insertions(+), 37 deletions(-) > > diff --git a/Makefile b/Makefile > index 8606849..4f2bda1 100644 > --- a/Makefile > +++ b/Makefile > @@ -364,42 +364,5 @@ tar: > cd /tmp&& tar zcvf ~/$(FILE).tar.gz $(FILE) --exclude CVS --exclude .git --exclude .svn > rm -rf /tmp/$(FILE) > > -SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS)) > -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \ > - $(patsubst %-softmmu,qemu-system-%, \ > - $(SYSTEM_TARGETS))) > - > -USER_TARGETS=$(filter %-user,$(TARGET_DIRS)) > -USER_PROGS=$(patsubst %-bsd-user,qemu-%, \ > - $(patsubst %-darwin-user,qemu-%, \ > - $(patsubst %-linux-user,qemu-%, \ > - $(USER_TARGETS)))) > - > -# generate a binary distribution > -tarbin: > - cd /&& tar zcvf ~/qemu-$(VERSION)-$(ARCH).tar.gz \ > - $(patsubst %,$(bindir)/%, $(SYSTEM_PROGS)) \ > - $(patsubst %,$(bindir)/%, $(USER_PROGS)) \ > - $(bindir)/qemu-img \ > - $(bindir)/qemu-nbd \ > - $(datadir)/bios.bin \ > - $(datadir)/vgabios.bin \ > - $(datadir)/vgabios-cirrus.bin \ > - $(datadir)/ppc_rom.bin \ > - $(datadir)/openbios-sparc32 \ > - $(datadir)/openbios-sparc64 \ > - $(datadir)/openbios-ppc \ > - $(datadir)/pxe-e1000.rom \ > - $(datadir)/pxe-eepro100.rom \ > - $(datadir)/pxe-ne2k_pci.rom \ > - $(datadir)/pxe-pcnet.rom \ > - $(datadir)/pxe-rtl8139.rom \ > - $(datadir)/pxe-virtio.rom \ > - $(docdir)/qemu-doc.html \ > - $(docdir)/qemu-tech.html \ > - $(mandir)/man1/qemu.1 \ > - $(mandir)/man1/qemu-img.1 \ > - $(mandir)/man8/qemu-nbd.8 > - > # Include automatically generated dependency files > -include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d qapi/*.d qga/*.d)