From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4Z7F-0007UY-9I for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:10:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4Z79-0001Ru-8y for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:10:05 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:42464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4Z79-0001RZ-3n for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:09:59 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p8GDnDWI023269 for ; Fri, 16 Sep 2011 07:49:13 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8GE9ZHV171344 for ; Fri, 16 Sep 2011 08:09:44 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8GE9K69001748 for ; Fri, 16 Sep 2011 08:09:20 -0600 Message-ID: <4E73589E.7010308@us.ibm.com> Date: Fri, 16 Sep 2011 09:09:34 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4E71C4E0.9000007@siemens.com> In-Reply-To: <4E71C4E0.9000007@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On 09/15/2011 04:26 AM, Jan Kiszka wrote: > This does not yet unbreak PPC (which has its own problems) but > potentially other non-x86 systems where isa_mem_base is != 0. > > Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori > --- > hw/vga.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/vga.c b/hw/vga.c > index 125fb29..0a0c5a6 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -181,6 +181,7 @@ static void vga_update_memory_access(VGACommonState *s) > size = 0x8000; > break; > } > + base += isa_mem_base; > region = g_malloc(sizeof(*region)); > memory_region_init_alias(region, "vga.chain4",&s->vram, offset, size); > memory_region_add_subregion_overlap(s->legacy_address_space, base,