* [Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias
@ 2011-09-15 9:26 Jan Kiszka
2011-09-16 14:09 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2011-09-15 9:26 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
This does not yet unbreak PPC (which has its own problems) but
potentially other non-x86 systems where isa_mem_base is != 0.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/vga.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index 125fb29..0a0c5a6 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -181,6 +181,7 @@ static void vga_update_memory_access(VGACommonState *s)
size = 0x8000;
break;
}
+ base += isa_mem_base;
region = g_malloc(sizeof(*region));
memory_region_init_alias(region, "vga.chain4", &s->vram, offset, size);
memory_region_add_subregion_overlap(s->legacy_address_space, base,
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias
2011-09-15 9:26 [Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias Jan Kiszka
@ 2011-09-16 14:09 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-09-16 14:09 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
On 09/15/2011 04:26 AM, Jan Kiszka wrote:
> This does not yet unbreak PPC (which has its own problems) but
> potentially other non-x86 systems where isa_mem_base is != 0.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/vga.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/vga.c b/hw/vga.c
> index 125fb29..0a0c5a6 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -181,6 +181,7 @@ static void vga_update_memory_access(VGACommonState *s)
> size = 0x8000;
> break;
> }
> + base += isa_mem_base;
> region = g_malloc(sizeof(*region));
> memory_region_init_alias(region, "vga.chain4",&s->vram, offset, size);
> memory_region_add_subregion_overlap(s->legacy_address_space, base,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-16 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-15 9:26 [Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias Jan Kiszka
2011-09-16 14:09 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).