From: Stefan Weil <weil@mail.berlios.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 8/8] ppc: Support tcg interpreter on ppc hosts
Date: Sat, 17 Sep 2011 23:33:52 +0200 [thread overview]
Message-ID: <4E751240.5010803@mail.berlios.de> (raw)
In-Reply-To: <CAFEAcA_Ns6gRtNsU3Uzp1zGeek1TKnMaH4_LHNrjZzO58qrT8w@mail.gmail.com>
Am 17.09.2011 23:31, schrieb Peter Maydell:
> On 17 September 2011 21:00, Stefan Weil<weil@mail.berlios.de> wrote:
>> Tests of the tcg interpreter on an (emulated) ppc host
>> needed this small change.
>>
>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>> ---
>> cache-utils.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cache-utils.h b/cache-utils.h
>> index 0b65907..7c3b282 100644
>> --- a/cache-utils.h
>> +++ b/cache-utils.h
>> @@ -1,7 +1,7 @@
>> #ifndef QEMU_CACHE_UTILS_H
>> #define QEMU_CACHE_UTILS_H
>>
>> -#if defined(_ARCH_PPC)
>> +#if defined(_ARCH_PPC)&& !defined(CONFIG_TCG_INTERPRETER)
>> struct qemu_cache_conf {
>> unsigned long dcache_bsize;
>> unsigned long icache_bsize;
> This looks a bit odd, but I think that's partly an effect of
> only the PPC flush_icache_range being in this header file when
> for other architectures it is in tcg/*/tcg-target.h. If we
> could have the cache flushing be in tcg/* for every target then
> you wouldn't need to do an ifdef here.
>
> -- PMM
That's correct.
next prev parent reply other threads:[~2011-09-17 21:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-17 19:59 [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine) Stefan Weil
2011-09-17 20:00 ` [Qemu-devel] [PATCH 1/8] tcg: Declare TCG_TARGET_REG_BITS in tcg.h Stefan Weil
2011-09-17 20:00 ` [Qemu-devel] [PATCH 2/8] tcg: Don't declare TCG_TARGET_REG_BITS in tcg-target.h Stefan Weil
2011-09-17 20:00 ` [Qemu-devel] [PATCH 3/8] tcg: Add forward declarations for local functions Stefan Weil
2011-09-17 21:40 ` Peter Maydell
2011-09-17 20:00 ` [Qemu-devel] [PATCH 4/8] tcg: Add some assertions Stefan Weil
2011-09-17 20:00 ` [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode Stefan Weil
2011-09-18 4:03 ` Andi Kleen
2011-09-18 5:49 ` Stefan Weil
2011-09-18 7:22 ` Paolo Bonzini
2011-09-18 17:54 ` Avi Kivity
2011-09-19 6:52 ` Andi Kleen
2011-09-19 11:56 ` Avi Kivity
2011-09-19 14:48 ` Andi Kleen
2011-09-18 10:18 ` Blue Swirl
2011-09-19 16:43 ` Richard Henderson
2011-09-19 20:24 ` Stuart Brady
2011-10-16 21:54 ` Stuart Brady
2011-09-17 20:00 ` [Qemu-devel] [PATCH 6/8] tcg: Add bytecode generator for tcg interpreter Stefan Weil
2011-09-18 10:03 ` Blue Swirl
2011-09-19 22:28 ` Stuart Brady
2011-10-01 16:54 ` Andreas Färber
2011-10-01 21:25 ` Stefan Weil
2011-10-09 16:19 ` Andreas Färber
2011-09-17 20:00 ` [Qemu-devel] [PATCH 7/8] tcg: Add tcg interpreter to configure / make Stefan Weil
2011-09-18 9:37 ` Blue Swirl
2011-09-18 10:14 ` Stefan Weil
2011-09-17 20:00 ` [Qemu-devel] [PATCH 8/8] ppc: Support tcg interpreter on ppc hosts Stefan Weil
2011-09-17 21:31 ` Peter Maydell
2011-09-17 21:33 ` Stefan Weil [this message]
2011-09-18 10:26 ` [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine) Blue Swirl
2011-09-18 10:49 ` malc
2011-09-18 12:12 ` Blue Swirl
2011-09-18 12:46 ` malc
2011-09-18 13:00 ` Blue Swirl
2011-09-18 13:13 ` malc
2011-09-18 13:26 ` Blue Swirl
2011-09-25 20:37 ` Stefan Weil
2011-10-01 12:02 ` Blue Swirl
2011-09-18 15:02 ` Mulyadi Santosa
2011-09-18 15:13 ` Stefan Weil
2011-09-18 16:39 ` Mulyadi Santosa
2011-09-18 20:15 ` Stefan Weil
2011-09-19 15:14 ` Mulyadi Santosa
2011-09-19 8:40 ` David Gilbert
2011-09-19 10:20 ` Stefan Hajnoczi
2011-09-19 10:27 ` David Gilbert
2011-09-18 18:02 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E751240.5010803@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).