From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47064)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R5G76-00015N-He
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 08:04:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R5G75-0006vX-CH
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 08:04:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50391)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R5G75-0006vO-5M
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 08:04:47 -0400
Message-ID: <4E75DE5A.3050005@redhat.com>
Date: Sun, 18 Sep 2011 15:04:42 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1315832873-18976-1-git-send-email-avi@redhat.com>
	<4E709763.1080805@redhat.com> <4E70D40D.108@googlemail.com>
	<4E710BF2.9060404@redhat.com> <20110914205200.GD17136@zapo>
In-Reply-To: <20110914205200.GD17136@zapo>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization
 after piix4 initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: hpoussin@reactos.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <planche2k@googlemail.com>, qemu-devel@nongnu.org

On 09/14/2011 11:52 PM, Edgar E. Iglesias wrote:
> On Wed, Sep 14, 2011 at 11:17:54PM +0300, Avi Kivity wrote:
> >  On 09/14/2011 07:19 PM, Andreas F=E4rber wrote:
> >  >>
> >  >>   Can this please be reviewed?  It's in the front of the memory q=
ueue
> >  >>   logjam.
> >  >
> >  >With or without this patch, the mips and mipsel test images on qemu=
.org
> >  >produce no output at all, on x64 host.
> >  >
> >
> >  AFAICT this problem predates the memory API.  I'm looking more for
> >  criticism on the approach.
>
> Hi, i think the images on the wiki are meant to run on a -M mips board.
> Maybe the scripts predate a change to Malta as default board, don't kno=
w.
>
> The patch looks OK to me to, but you could maybe put a comment in the c=
ode
> to explain the indirection.
>

Thanks, added a comment and your acked-by.

--=20
error compiling committee.c: too many arguments to function