From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5HYW-0008Ue-46 for qemu-devel@nongnu.org; Sun, 18 Sep 2011 09:37:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5HYU-0007se-JH for qemu-devel@nongnu.org; Sun, 18 Sep 2011 09:37:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5HYU-0007sL-CP for qemu-devel@nongnu.org; Sun, 18 Sep 2011 09:37:10 -0400 Message-ID: <4E75F401.2000607@redhat.com> Date: Sun, 18 Sep 2011 16:37:05 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1316350706-21602-1-git-send-email-avi@redhat.com> In-Reply-To: <1316350706-21602-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] irq: introduce qemu_irq_proxy() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , Anthony Liguori , qemu-devel@nongnu.org On 09/18/2011 03:58 PM, Avi Kivity wrote: > In some cases we have a circular dependency involving irqs - the irq > controller depends on a bus, which in turn depends on the irq controller. > Add qemu_irq_proxy() which acts as a passthrough, except that the target > irq may be set later on. > > Signed-off-by: Avi Kivity > --- > > Turns out the circular dependency i8259->isa->pci->i8259 is widespread, > so introduce a general means of fixing it up. I'll update the patchset to > make use of it everywhere it occurs. In fact the other cases were solved without qemu_irq_proxy(), but I think qemu_irq_proxy() is nicer than the previous patch, so I'll keep it if no one objects. -- error compiling committee.c: too many arguments to function