From: Richard Henderson <rth@twiddle.net>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses
Date: Sun, 18 Sep 2011 07:44:56 -0700 [thread overview]
Message-ID: <4E7603E8.7080106@twiddle.net> (raw)
In-Reply-To: <4E75E7A4.50702@web.de>
On 09/18/2011 05:44 AM, Jan Kiszka wrote:
> + *data = mrp->read(mr->opaque, offset + mr->offset) |
> + mrp->read(mr->opaque, offset + mr->offset + 1);
Missing shift.
Also, a comment about the fact that the legacy interface doesn't
handle size 4 would also be welcome.
r~
prev parent reply other threads:[~2011-09-18 14:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 12:44 [Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses Jan Kiszka
2011-09-18 12:51 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-09-18 15:37 ` Avi Kivity
2011-09-18 15:43 ` Jan Kiszka
2011-09-18 15:45 ` Avi Kivity
2011-09-18 16:28 ` Jan Kiszka
2011-09-18 16:49 ` Avi Kivity
2011-09-18 19:07 ` Jan Kiszka
2011-09-19 12:19 ` Avi Kivity
2011-09-19 12:32 ` Jan Kiszka
2011-09-19 12:42 ` Avi Kivity
2011-09-19 12:55 ` Jan Kiszka
2011-09-19 13:09 ` Avi Kivity
2011-09-19 13:55 ` Gerd Hoffmann
2011-09-19 13:58 ` Avi Kivity
2011-09-26 13:30 ` Avi Kivity
2011-09-18 14:44 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7603E8.7080106@twiddle.net \
--to=rth@twiddle.net \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).