From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5Ic9-0006k8-7B for qemu-devel@nongnu.org; Sun, 18 Sep 2011 10:45:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5Ic8-0004qV-BO for qemu-devel@nongnu.org; Sun, 18 Sep 2011 10:45:01 -0400 Received: from mail-gw0-f53.google.com ([74.125.83.53]:54691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5Ic8-0004qO-8h for qemu-devel@nongnu.org; Sun, 18 Sep 2011 10:45:00 -0400 Received: by gwj20 with SMTP id 20so4893173gwj.12 for ; Sun, 18 Sep 2011 07:44:59 -0700 (PDT) Sender: Richard Henderson Message-ID: <4E7603E8.7080106@twiddle.net> Date: Sun, 18 Sep 2011 07:44:56 -0700 From: Richard Henderson MIME-Version: 1.0 References: <4E75E7A4.50702@web.de> In-Reply-To: <4E75E7A4.50702@web.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Avi Kivity , qemu-devel On 09/18/2011 05:44 AM, Jan Kiszka wrote: > + *data = mrp->read(mr->opaque, offset + mr->offset) | > + mrp->read(mr->opaque, offset + mr->offset + 1); Missing shift. Also, a comment about the fact that the legacy interface doesn't handle size 4 would also be welcome. r~