From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5J9k-0002jK-Gs for qemu-devel@nongnu.org; Sun, 18 Sep 2011 11:19:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5J9j-0004OE-Oo for qemu-devel@nongnu.org; Sun, 18 Sep 2011 11:19:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5J9j-0004OA-Fx for qemu-devel@nongnu.org; Sun, 18 Sep 2011 11:19:43 -0400 Message-ID: <4E760C04.5070103@redhat.com> Date: Sun, 18 Sep 2011 18:19:32 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1314144835-29098-1-git-send-email-rth@twiddle.net> <1314144835-29098-13-git-send-email-rth@twiddle.net> <4E75F611.5070806@redhat.com> <4E75FD3C.4030304@twiddle.net> <4E75FFEF.7060603@redhat.com> <4E76069B.2050907@redhat.com> <4E760B2D.4020703@twiddle.net> In-Reply-To: <4E760B2D.4020703@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, Alexander Graf On 09/18/2011 06:15 PM, Richard Henderson wrote: > On 09/18/2011 07:56 AM, Avi Kivity wrote: > > It's also wrong for cirrus. Even though it is a legacy address, it's > > not an ISA address, it's on the PCI bus (though not mapped by a BAR). > > Huh? How do define that as not an ISA address? Especially > since all that's called from isa_cirrus_vga_init? > Ah, sorry, cirrus/pci indeed has its own ioports registration which doesn't go through isa. So it's actually the opposite problem - generic port registration instead of bus-specific registration. As soon as we convert it, we'll have the same problem again. -- error compiling committee.c: too many arguments to function