From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48527)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R5JeI-0003ii-Gw
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 11:51:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R5JeH-0002BR-EG
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 11:51:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4984)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R5JeH-0002BM-5x
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 11:51:17 -0400
Message-ID: <4E761371.3020007@redhat.com>
Date: Sun, 18 Sep 2011 18:51:13 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4E75E7B0.9080104@web.de>
In-Reply-To: <4E75E7B0.9080104@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion
	fallouts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

On 09/18/2011 03:44 PM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> ---
>
>   #ifdef CONFIG_BOCHS_VBE
>   static const MemoryRegionPortio vbe_portio_list[] = {
> -# ifdef TARGET_I386
>       { 0, 1, 2, .read = vbe_ioport_read_index, .write = vbe_ioport_write_index },
> +# ifdef TARGET_I386

Strange how the card knows what target it's plugged into.  Fixing this 
is going to involve major pain - need to update the bios and need to 
provide backwards compatibility.  All this assuming guests don't 
hardcode the address.

Anyway I find the deduplication makes the code harder to read.

>       { 1, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data },
>   # else
> -    { 0, 2, 2, .read = vbe_ioport_read_index, .write = vbe_ioport_write_index },
> -    { 2, 2, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data },
> +    { 2, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data },

Is this correct?  length 1 region with size 2?


-- 
error compiling committee.c: too many arguments to function