From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50760)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R5KEH-0005Ro-1Z
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:28:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R5KEF-0001PM-FY
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:28:29 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:60011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R5KEF-0001PD-26
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:28:27 -0400
Message-ID: <4E761C29.8070304@web.de>
Date: Sun, 18 Sep 2011 18:28:25 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4E75E7B0.9080104@web.de> <4E761371.3020007@redhat.com>
In-Reply-To: <4E761371.3020007@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigF79A9DB424C0EBE6AE7D5DC1"
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion
	fallouts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigF79A9DB424C0EBE6AE7D5DC1
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-09-18 17:51, Avi Kivity wrote:
> On 09/18/2011 03:44 PM, Jan Kiszka wrote:
>> From: Jan Kiszka<jan.kiszka@siemens.com>
>>
>> Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges.=

>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>> ---
>>
>>   #ifdef CONFIG_BOCHS_VBE
>>   static const MemoryRegionPortio vbe_portio_list[] =3D {
>> -# ifdef TARGET_I386
>>       { 0, 1, 2, .read =3D vbe_ioport_read_index, .write =3D
>> vbe_ioport_write_index },
>> +# ifdef TARGET_I386
>=20
> Strange how the card knows what target it's plugged into.  Fixing this
> is going to involve major pain - need to update the bios and need to
> provide backwards compatibility.  All this assuming guests don't
> hardcode the address.
>=20
> Anyway I find the deduplication makes the code harder to read.

That line is rather tricky to deduplicate in mind. So it's not nice for
our readers keeping it duplicated around.

>=20
>>       { 1, 1, 2, .read =3D vbe_ioport_read_data, .write =3D
>> vbe_ioport_write_data },
>>   # else
>> -    { 0, 2, 2, .read =3D vbe_ioport_read_index, .write =3D
>> vbe_ioport_write_index },
>> -    { 2, 2, 2, .read =3D vbe_ioport_read_data, .write =3D
>> vbe_ioport_write_data },
>> +    { 2, 1, 2, .read =3D vbe_ioport_read_data, .write =3D
>> vbe_ioport_write_data },
>=20
> Is this correct?  length 1 region with size 2?

Yes, it prevents accesses on base+1.

Jan


--------------enigF79A9DB424C0EBE6AE7D5DC1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk52HCkACgkQitSsb3rl5xSdKwCg0ZJ0FLEgiMnwpTay5H9dGQIf
oHcAniB+J5aDH0M6klHKJC4VrOeu/xPE
=h92z
-----END PGP SIGNATURE-----

--------------enigF79A9DB424C0EBE6AE7D5DC1--