From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5KVl-0001mZ-J8 for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5KVk-0005RT-5L for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:46:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5KVj-0005RJ-Su for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:46:32 -0400 Message-ID: <4E762064.6010108@redhat.com> Date: Sun, 18 Sep 2011 19:46:28 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E75EA08.4090809@web.de> <4E7614CC.4000206@redhat.com> <4E761C66.9010208@web.de> In-Reply-To: <4E761C66.9010208@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Richard Henderson On 09/18/2011 07:29 PM, Jan Kiszka wrote: > On 2011-09-18 17:57, Avi Kivity wrote: > > On 09/18/2011 03:54 PM, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> We can express the offset of old portio completely via > >> MemoryRegionPortio::offset by splitting up regions of different offsets > >> and adjusting those offsets appropriately. > > > > Please split into two patches - core and isa. > > They depend on each other. How can memory.c depend on isa.c? If you make the core patch add both mr->offset and mrp->offset, then change isa to drop memory_region_set_offset(), instead adding the delta to mrp->offset, does that not work out? > > And I > > don't want to remove memory_region_set_offset() until everything (that > > can potentially use it, at least) has been converted. > > IMO it's easier to fix those potential users before converting them. You > need to review them anyway to decide if an offset might be needed, and > which one precisely. > > Are you aware of any candidates? For PIO, there should be none now. For pio, none, but mmio has some: hw/sh7750.c: cpu_register_physical_memory_offset(0x1f000000, 0x1000, hw/sh7750.c: cpu_register_physical_memory_offset(0xff000000, 0x1000, hw/sh7750.c: cpu_register_physical_memory_offset(0x1f800000, 0x1000, hw/sh7750.c: cpu_register_physical_memory_offset(0xff800000, 0x1000, hw/sh7750.c: cpu_register_physical_memory_offset(0x1fc00000, 0x1000, hw/sh7750.c: cpu_register_physical_memory_offset(0xffc00000, 0x1000, hw/sh_intc.c: cpu_register_physical_memory_offset(P4ADDR(address), 4, hw/sh_intc.c: cpu_register_physical_memory_offset(A7ADDR(address), 4, -- error compiling committee.c: too many arguments to function