From: Richard Henderson <rth@twiddle.net>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio
Date: Sun, 18 Sep 2011 09:49:35 -0700 [thread overview]
Message-ID: <4E76211F.7010901@twiddle.net> (raw)
In-Reply-To: <4E75EA08.4090809@web.de>
On 09/18/2011 05:54 AM, Jan Kiszka wrote:
> @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(MemoryRegion *mr, uint64_t offset,
> const MemoryRegionPortio *mrp;
>
> for (mrp = mr->ops->old_portio; mrp->size; ++mrp) {
> - if (offset >= mrp->offset && offset < mrp->offset + mrp->len
> - && width == mrp->size
> + if (offset < mrp->len && width == mrp->size
This change looks broken to me. How, exactly, are you
disambiguating different entries?
r~
next prev parent reply other threads:[~2011-09-18 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 12:54 [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio Jan Kiszka
2011-09-18 13:09 ` [Qemu-devel] [PATCH] memory: Eliminate region offset Jan Kiszka
2011-09-18 15:57 ` [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio Avi Kivity
2011-09-18 16:29 ` Jan Kiszka
2011-09-18 16:46 ` Avi Kivity
2011-09-18 19:04 ` Jan Kiszka
2011-09-19 12:14 ` Avi Kivity
2011-09-19 12:29 ` Jan Kiszka
2011-09-19 12:37 ` Avi Kivity
2011-09-19 12:48 ` Jan Kiszka
2011-09-19 12:59 ` Avi Kivity
2011-09-18 16:49 ` Richard Henderson [this message]
2011-09-18 19:16 ` Jan Kiszka
2011-09-19 12:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E76211F.7010901@twiddle.net \
--to=rth@twiddle.net \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).