From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53070)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R5KYl-0002xY-JE
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:49:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R5KYk-0005ub-HF
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:49:39 -0400
Received: from mail-iy0-f173.google.com ([209.85.210.173]:56540)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R5KYk-0005tT-AB
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 12:49:38 -0400
Received: by iagf6 with SMTP id f6so5558854iag.4
	for <qemu-devel@nongnu.org>; Sun, 18 Sep 2011 09:49:37 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E76211F.7010901@twiddle.net>
Date: Sun, 18 Sep 2011 09:49:35 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <4E75EA08.4090809@web.de>
In-Reply-To: <4E75EA08.4090809@web.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete
 memory_region_set_offset for old portio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/18/2011 05:54 AM, Jan Kiszka wrote:
> @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(MemoryRegion *mr, uint64_t offset,
>      const MemoryRegionPortio *mrp;
>  
>      for (mrp = mr->ops->old_portio; mrp->size; ++mrp) {
> -        if (offset >= mrp->offset && offset < mrp->offset + mrp->len
> -            && width == mrp->size
> +        if (offset < mrp->len && width == mrp->size

This change looks broken to me.  How, exactly, are you 
disambiguating different entries?



r~