From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5Mik-00006k-9O for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:08:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5Mih-0002OD-Tc for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:08:06 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:56221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5Mih-0002O2-CS for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:08:03 -0400 Message-ID: <4E76417C.50301@web.de> Date: Sun, 18 Sep 2011 21:07:40 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E75E7B0.9080104@web.de> <4E761371.3020007@redhat.com> <4E761C29.8070304@web.de> <4E7621A2.7070406@redhat.com> In-Reply-To: <4E7621A2.7070406@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEDA7425D9B1CA72944005D53" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel , Richard Henderson This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEDA7425D9B1CA72944005D53 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-09-18 18:51, Avi Kivity wrote: > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> On 2011-09-18 17:51, Avi Kivity wrote: >> > On 09/18/2011 03:44 PM, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> >> >> Fix copy&paste errors and reduce duplications of the BOCHS VBE >> ranges. >> >> >> >> Signed-off-by: Jan Kiszka >> >> --- >> >> >> >> #ifdef CONFIG_BOCHS_VBE >> >> static const MemoryRegionPortio vbe_portio_list[] =3D { >> >> -# ifdef TARGET_I386 >> >> { 0, 1, 2, .read =3D vbe_ioport_read_index, .write =3D >> >> vbe_ioport_write_index }, >> >> +# ifdef TARGET_I386 >> > >> > Strange how the card knows what target it's plugged into. Fixing t= his >> > is going to involve major pain - need to update the bios and need t= o >> > provide backwards compatibility. All this assuming guests don't >> > hardcode the address. >> > >> > Anyway I find the deduplication makes the code harder to read. >> >> That line is rather tricky to deduplicate in mind. So it's not nice fo= r >> our readers keeping it duplicated around. >=20 > I don't think it should be deduplicated. The device is providing two > separate ABIs. Yes, two ABIs, and the only difference is the offset of the data register= =2E >=20 >> > >> >> { 1, 1, 2, .read =3D vbe_ioport_read_data, .write =3D >> >> vbe_ioport_write_data }, >> >> # else >> >> - { 0, 2, 2, .read =3D vbe_ioport_read_index, .write =3D >> >> vbe_ioport_write_index }, >> >> - { 2, 2, 2, .read =3D vbe_ioport_read_data, .write =3D >> >> vbe_ioport_write_data }, >> >> + { 2, 1, 2, .read =3D vbe_ioport_read_data, .write =3D >> >> vbe_ioport_write_data }, >> > >> > Is this correct? length 1 region with size 2? >> >> Yes, it prevents accesses on base+1. >> >=20 > Why disallow it? Did anyone check that something useful or at least valid comes out of the handlers when doing this so far impossible access? Jan --------------enigEDA7425D9B1CA72944005D53 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk52QXwACgkQitSsb3rl5xSZfwCg7BlNXEj7CtHMJNLRqIXj3q+I X1YAoIyXv19deO4+/kSbA9mqQwoCdQ11 =QDOj -----END PGP SIGNATURE----- --------------enigEDA7425D9B1CA72944005D53--