From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57669)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R5Mqh-0001x6-UJ
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:16:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R5Mqg-0004DF-Ck
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:16:19 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:33441)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R5Mqg-0004D2-2F
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:16:18 -0400
Message-ID: <4E764380.1030206@web.de>
Date: Sun, 18 Sep 2011 21:16:16 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4E75EA08.4090809@web.de> <4E76211F.7010901@twiddle.net>
In-Reply-To: <4E76211F.7010901@twiddle.net>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig1AA96B01CBD40E1A31C1C9FE"
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete
 memory_region_set_offset for old portio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig1AA96B01CBD40E1A31C1C9FE
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-09-18 18:49, Richard Henderson wrote:
> On 09/18/2011 05:54 AM, Jan Kiszka wrote:
>> @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(Memor=
yRegion *mr, uint64_t offset,
>>      const MemoryRegionPortio *mrp;
>> =20
>>      for (mrp =3D mr->ops->old_portio; mrp->size; ++mrp) {
>> -        if (offset >=3D mrp->offset && offset < mrp->offset + mrp->le=
n
>> -            && width =3D=3D mrp->size
>> +        if (offset < mrp->len && width =3D=3D mrp->size
>=20
> This change looks broken to me.  How, exactly, are you=20
> disambiguating different entries?

See my reply to Avi: all offsets of an portio region must be the same.

They should actually only differ in access width, but there is still at
least one counter example (of course IDE...). Given that this is just a
portability helper, all this will likely be reviewed and cleaned up when
getting rid of old portio.

Jan


--------------enig1AA96B01CBD40E1A31C1C9FE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk52Q4AACgkQitSsb3rl5xRsDwCdGG9Yd/w5Kg3SNe+gYj/zAg6L
XYcAnA9r+/RnLYMnDB+iljGctAsf/IPr
=idhR
-----END PGP SIGNATURE-----

--------------enig1AA96B01CBD40E1A31C1C9FE--