From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5clQ-0006ia-AX for qemu-devel@nongnu.org; Mon, 19 Sep 2011 08:15:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5clP-0003ls-9p for qemu-devel@nongnu.org; Mon, 19 Sep 2011 08:15:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5clP-0003le-2m for qemu-devel@nongnu.org; Mon, 19 Sep 2011 08:15:55 -0400 Message-ID: <4E773277.8080306@redhat.com> Date: Mon, 19 Sep 2011 15:15:51 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E75EA08.4090809@web.de> <4E76211F.7010901@twiddle.net> <4E764380.1030206@web.de> In-Reply-To: <4E764380.1030206@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Richard Henderson On 09/18/2011 10:16 PM, Jan Kiszka wrote: > On 2011-09-18 18:49, Richard Henderson wrote: > > On 09/18/2011 05:54 AM, Jan Kiszka wrote: > >> @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(MemoryRegion *mr, uint64_t offset, > >> const MemoryRegionPortio *mrp; > >> > >> for (mrp = mr->ops->old_portio; mrp->size; ++mrp) { > >> - if (offset>= mrp->offset&& offset< mrp->offset + mrp->len > >> -&& width == mrp->size > >> + if (offset< mrp->len&& width == mrp->size > > > > This change looks broken to me. How, exactly, are you > > disambiguating different entries? > > See my reply to Avi: all offsets of an portio region must be the same. Said Avi doesn't understand. VGA for example has many ports. Or are you saying, split the input into sets of discontinuous ports, within each set you can use only one offset? > > They should actually only differ in access width, but there is still at > least one counter example (of course IDE...). Given that this is just a > portability helper, all this will likely be reviewed and cleaned up when > getting rid of old portio. -- error compiling committee.c: too many arguments to function