From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts
Date: Mon, 19 Sep 2011 15:22:21 +0300 [thread overview]
Message-ID: <4E7733FD.3080006@redhat.com> (raw)
In-Reply-To: <4E76417C.50301@web.de>
On 09/18/2011 10:07 PM, Jan Kiszka wrote:
> > I don't think it should be deduplicated. The device is providing two
> > separate ABIs.
>
> Yes, two ABIs, and the only difference is the offset of the data register.
How about
#ifdef TARGET_I386
# define VBE_DATA_REG 1
#else
# define VBE_DATA_REG 2
#endif
> >
> > Why disallow it?
>
> Did anyone check that something useful or at least valid comes out of
> the handlers when doing this so far impossible access?
>
It's a general problem. It can't be fixed in devices, the core has to
handle this (and devices have to tell it how to react to such accesses).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-09-19 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 12:44 [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts Jan Kiszka
2011-09-18 15:51 ` Avi Kivity
2011-09-18 16:28 ` Jan Kiszka
2011-09-18 16:51 ` Avi Kivity
2011-09-18 19:07 ` Jan Kiszka
2011-09-19 12:22 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7733FD.3080006@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).