From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5crj-00005L-7m for qemu-devel@nongnu.org; Mon, 19 Sep 2011 08:22:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5cri-0004wP-2y for qemu-devel@nongnu.org; Mon, 19 Sep 2011 08:22:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5crh-0004wL-Qz for qemu-devel@nongnu.org; Mon, 19 Sep 2011 08:22:26 -0400 Message-ID: <4E7733FD.3080006@redhat.com> Date: Mon, 19 Sep 2011 15:22:21 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E75E7B0.9080104@web.de> <4E761371.3020007@redhat.com> <4E761C29.8070304@web.de> <4E7621A2.7070406@redhat.com> <4E76417C.50301@web.de> In-Reply-To: <4E76417C.50301@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Richard Henderson On 09/18/2011 10:07 PM, Jan Kiszka wrote: > > I don't think it should be deduplicated. The device is providing two > > separate ABIs. > > Yes, two ABIs, and the only difference is the offset of the data register. How about #ifdef TARGET_I386 # define VBE_DATA_REG 1 #else # define VBE_DATA_REG 2 #endif > > > > Why disallow it? > > Did anyone check that something useful or at least valid comes out of > the handlers when doing this so far impossible access? > It's a general problem. It can't be fixed in devices, the core has to handle this (and devices have to tell it how to react to such accesses). -- error compiling committee.c: too many arguments to function