From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5ejP-0002m3-Ro for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:22:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5ejL-0006JB-JT for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:21:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5ejL-0006J5-8n for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:21:55 -0400 Message-ID: <4E7750B1.2010509@redhat.com> Date: Mon, 19 Sep 2011 16:24:49 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1316188834-13675-1-git-send-email-aliguori@us.ibm.com> <4E737DC9.5010208@siemens.com> <4E737F4C.7060907@codemonkey.ws> <4E738348.3080004@redhat.com> <4E738F65.3050403@codemonkey.ws> <4E76EE9F.3020109@siemens.com> <4E774C1D.4050000@codemonkey.ws> In-Reply-To: <4E774C1D.4050000@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Jan Kiszka , "qemu-devel@nongnu.org" , Markus Armbruster , Paolo Bonzini Am 19.09.2011 16:05, schrieb Anthony Liguori: > On 09/19/2011 02:26 AM, Jan Kiszka wrote: >> On 2011-09-16 20:03, Anthony Liguori wrote: >>> So this is a simplification that I plan on running with. For now, I think this >>> series is the right next step because it gives us a path name for the name >>> (although different syntax) and let's us enforce that all devices has a >>> canonical path. >> >> For something that changes lots of devices and, at the same time, is >> going to be removed again, I'm hesitating to call it the right direction. >> >> A right step would be, IMHO, to introduce a generic introspectable >> device link so that parent devices can reference their children and a >> visitor can derive a child's relative name from that link name. Then >> make sure this link type is consistently used. >> >> I really dislike this focusing on assigning names internally and using >> them in QEMU-internal APIs. They should just fall out of the core when >> external interaction is required. > > I thought a lot about this over the weekend and decided that I should go in a > different direction based on this discussion. > [...] Sounds like a good direction to me. (At least until someone brings up the details :-)) Kevin