From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5fHV-0007i2-FK for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:57:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5fHP-0006ij-Ve for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:57:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5fHP-0006ie-K1 for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:57:07 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8JEv6LT030553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 19 Sep 2011 10:57:06 -0400 Message-ID: <4E7758F4.8070003@redhat.com> Date: Mon, 19 Sep 2011 17:00:04 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1315579646-6874-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1315579646-6874-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi: fix sign extension problems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 09.09.2011 16:47, schrieb Paolo Bonzini: > When assigning a 32-bit value to cmd->xfer (which is 64-bits) > it can be erroneously sign extended because the intermediate > 32-bit computation is signed. Fix this by standardizing on > the ld*_be_p functions. > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin