From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36300)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R5gwE-0003un-Jm
	for qemu-devel@nongnu.org; Mon, 19 Sep 2011 12:43:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R5gwD-000492-ES
	for qemu-devel@nongnu.org; Mon, 19 Sep 2011 12:43:22 -0400
Received: from mail-wy0-f181.google.com ([74.125.82.181]:38161)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R5gwD-00048p-9m
	for qemu-devel@nongnu.org; Mon, 19 Sep 2011 12:43:21 -0400
Received: by wyg36 with SMTP id 36so6397644wyg.12
	for <qemu-devel@nongnu.org>; Mon, 19 Sep 2011 09:43:20 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E777122.7060504@twiddle.net>
Date: Mon, 19 Sep 2011 09:43:14 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <4E74FC29.1050003@mail.berlios.de>
	<1316289634-18786-5-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1316289634-18786-5-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 09/17/2011 01:00 PM, Stefan Weil wrote:
> +#if TCG_TARGET_HAS_ext8s_i32
> +        case INDEX_op_ext8s_i32:
> +            t0 = *tb_ptr++;
> +            t1 = tci_read_r8s(&tb_ptr);
> +            tci_write_reg32(t0, t1);
> +            break;
> +#endif

You really ought not need all these ifdefs.

> +#if TCG_TARGET_HAS_rot_i64
> +        case INDEX_op_rotl_i64:
> +        case INDEX_op_rotr_i64:
> +            TODO();
> +            break;
> +#endif

Eh?  Just the same as your rot_i32 implementations,
with different types.


r~